Thread: CTL^D not ending my stdin loop

Can someone explain to me why CTL^D is not ending this loop? My fp has been set to stdin in my main.c Can you also suggest a way that I can do it? Thank You!

Code:

#include "main.h"

int fileCheck(FILE *fp)
{

    int line_count = 0;
    char file[BUFF];
    char check[BUFF];

    while (fgets(file, BUFF, fp) !=NULL)
    {
        fscanf(fp, "%s", &check);
        if (check == "\n");
        {
            line_count++;
        }

    }
    printf("Line count: %d\n", line_count);
}

What operating system are you using?

Are you entering this on an empty line?

Do you realize that fgets() retrieves the end of line character ('\n')?


Jim

Originally Posted by jimblumberg

What operating system are you using?

Are you entering this on an empty line?

Do you realize that fgets() retrieves the end of line character ('\n')?


Jim

Unix on a Sun Solaris, yes and yes. The problem was fscanf. It was removed. Thank You.

Originally Posted by Salem

> if (check == "\n");
Please tell me you're getting warnings for this line.
It's broken at least twice.

No and I compile with gcc -Wall flag. What do you mean by "broken?"

Originally Posted by Salem

Really?

Code:

$ gcc -Wall foo.c
foo.c: In function ‘fileCheck’:
foo.c:18:9: warning: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘char (*)[100]’ [-Wformat]
foo.c:19:19: warning: comparison with string literal results in unspecified behavior [-Waddress]
foo.c:26:1: warning: control reaches end of non-void function [-Wreturn-type]
$ gcc --version
gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

You can't compare strings with ==, you need to use strcmp()
The ; at the end of the line renders the if statement useless.

Got it, see revised code:

Code:

#include "main.h"

int fileCheck(FILE *fp)
{

    int line_count = 0;
    char file[BUFF];
    char check[BUFF];
    char new_line[] = "\n";
    char *line;
    regex_t regex;

    /*if (regcomp(&regex, to_find, REG_EXTENDED) != 0)
    {
        fprintf(stderr, "Failed to compile regex '%s'\n", to_find);
        return EXIT_FAILURE;
    }*/

    while (fgets(file, BUFF, fp) != NULL)
    {
        if (strcmp(file, new_line) == 0);
        {
            line_count++;
        }

        /*if (regexec(&regex, file, 0, NULL, 0) != 0)
        {
            printf("Digit: %s is not alphanumeric on line %d !\n", file, line_count);
            return EXIT_FAILURE;
        }*/

    }
    printf("Line count: %d\n", line_count);
}

It seems more likely that you want strchr, which will tell you if '\n' occurs anywhere in the string.

Code:

if (strchr(file, '\n')) line_count++;

Unless you actually want to count empty lines?

The regular expression library seems like overkill. You can achieve a similar thing with isupper or, if you plan on converting the numeric string, just use strtol/strtod or something.

Originally Posted by Barney McGrew

It seems more likely that you want strchr, which will tell you if '\n' occurs anywhere in the string.

Code:

if (strchr(file, '\n')) line_count++;

Unless you actually want to count empty lines?

The regular expression library seems like overkill. You can achieve a similar thing with isupper or, if you plan on converting the numeric string, just use strtol/strtod or something.

I do want to count empty lines. I must print an error message with the error and which line it occurs on.